feature(protoc-gen-prost-serde): add "feature" option - #134
Merged
Conversation
Contributor
Author
|
@siennathesane I'd appreciate your opinion on this 🙏 I implemented this cause I wasn't able to find any reasonable workaround for the use case "I want Serde only when "serde" is enabled". |
Collaborator
|
I think I can be okay with this. Can you please add an example, or update an example with this? That way folks can understand how it's used. |
Contributor
Author
|
@siennathesane added the usage example to existing example code. Also fixed a bug in the implementation I've made 🙈 |
siennathesane
approved these changes
Jan 19, 2026
siennathesane
left a comment
siennathesane
left a comment
Collaborator
There was a problem hiding this comment.
lgtm, thanks for the contribution! I'll release this soon.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
feature(=<string>)option to add to generatedincludedirectives. This is helpful if you want to enable Serde support by a Cargo feature of your crate. With this option used allinclude-s will look like: